Repository navigation
test: migrate stats/incr/rss to ULP-based assertions - #16005
Merged
Merged
Conversation
Replaces relative tolerance comparisons with ULP difference assertions using `@stdlib/assert/is-almost-same-value`. The accumulator returns bit-exact results for the test data, so the minimum required ULP difference is `0`. Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Rg1yBjjTZyER7PGJBCkzga --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
stdlib-bot
added
Statistics
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
marked this pull request as ready for review
October 11, 2026 12:42
stdlib-bot
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/incr/rssfrom relative tolerance testing to ULP difference testing.@stdlib/math/base/special/absand@stdlib/constants/float64/epsrequires with@stdlib/assert/is-almost-same-value.delta/tolscratch variables and theactual === expectedbranch, replacing each comparison witht.strictEqual( isAlmostSameValue( actual, expected, 0 ), true, 'returns expected value' );.Only
test/test.jsis modified; the package has notest/test.native.js.ULP bounds
The package has a single test file, and both affected test cases use the same bound:
test/test.js0The previous assertions allowed
1.0 * EPS * abs( expected ). Measuring the actual ULP difference for every assertion in the fixture set (via@stdlib/number/float64/base/ulp-difference) yields0for all seven comparisons, so the accumulator is bit-exact against the naive reference for this data and0is the minimum required ULP value.Verification:
make test TESTS_FILTER=".*/stats/incr/rss/.*"→ 11 passing, 0 failing.etc/eslint/.eslintrc.tests.js, via the pre-commit hook) reports no problems.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
The ULP value of
0meansisAlmostSameValuereduces to a SameValue comparison here. This matches the idiom already used in previously migrated packages in this family (e.g.stats/incr/mstdev,simulate/iter/periodic-sinc), where exactly representable results are asserted with a ULP value of0rather than being left as a tolerance comparison.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code running as an unattended scheduled task: it selected the package, studied the already-migrated packages to mirror the project's established idiom, applied the migration, and measured the minimum ULP bound empirically.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01Rg1yBjjTZyER7PGJBCkzga
Generated by Claude Code